Skip to content
This repository has been archived by the owner on Jan 8, 2022. It is now read-only.

feat: add max/min option for int and number builder options #47

Merged
merged 3 commits into from
Dec 22, 2021

Conversation

suneettipirneni
Copy link
Member

Please describe the changes this PR makes and why it should be merged:

Co-requisite with discordjs/discord-api-types#221

Status and versioning classification:
Please move lines that apply to you out of the comment:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #47 (e27d446) into main (24bfcd7) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #47   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        22    +1     
  Lines          264       279   +15     
  Branches        33        33           
=========================================
+ Hits           264       279   +15     
Impacted Files Coverage Δ
...ns/slashCommands/mixins/CommandNumberOptionBase.ts 100.00% <100.00%> (ø)
src/interactions/slashCommands/options/integer.ts 100.00% <100.00%> (ø)
src/interactions/slashCommands/options/number.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24bfcd7...e27d446. Read the comment docs.

Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge ready once typings land

@iCrawl iCrawl requested a review from SpaceEEC October 27, 2021 22:35
@kyranet
Copy link
Member

kyranet commented Oct 29, 2021

This needs a rebase.

@milanmdev
Copy link

image
Looks like the feature has been pushed to prod now.

@Mysterious-Dev

This comment has been minimized.

@iCrawl iCrawl merged commit 2e1e860 into discordjs:main Dec 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants