This repository has been archived by the owner on Jan 8, 2022. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 37
feat: add max/min option for int and number builder options #47
Merged
iCrawl
merged 3 commits into
discordjs:main
from
suneettipirneni:feat/min-max-number-options
Dec 22, 2021
Merged
feat: add max/min option for int and number builder options #47
iCrawl
merged 3 commits into
discordjs:main
from
suneettipirneni:feat/min-max-number-options
Dec 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladfrangu
suggested changes
Oct 19, 2021
src/interactions/slashCommands/mixins/CommandNumberOptionBase.ts
Outdated
Show resolved
Hide resolved
src/interactions/slashCommands/mixins/CommandNumberOptionBase.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #47 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 22 +1
Lines 264 279 +15
Branches 33 33
=========================================
+ Hits 264 279 +15
Continue to review full report at Codecov.
|
vladfrangu
approved these changes
Oct 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge ready once typings land
iCrawl
approved these changes
Oct 27, 2021
This needs a rebase. |
…t/min-max-number-options
Mysterious-Dev
approved these changes
Dec 13, 2021
This comment has been minimized.
This comment has been minimized.
SpaceEEC
approved these changes
Dec 21, 2021
kyranet
approved these changes
Dec 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Co-requisite with discordjs/discord-api-types#221
Status and versioning classification:
Please move lines that apply to you out of the comment: