-
-
Notifications
You must be signed in to change notification settings - Fork 37
feat(SlashCommandBuilder): add autocomplete #53
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some tiny nits.
Maybe add test cases to the methods where you check if an error is thrown, should both choices and autocomplete be provided.
src/interactions/slashCommands/mixins/CommandOptionWithChoices.ts
Outdated
Show resolved
Hide resolved
src/interactions/slashCommands/mixins/CommandOptionWithChoices.ts
Outdated
Show resolved
Hide resolved
src/interactions/slashCommands/mixins/CommandOptionWithChoices.ts
Outdated
Show resolved
Hide resolved
src/interactions/slashCommands/mixins/CommandOptionWithChoices.ts
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #53 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 264 276 +12
Branches 33 37 +4
=========================================
+ Hits 264 276 +12
Continue to review full report at Codecov.
|
My bad, I had already written the tests but forgot to commit them. |
Can you also add some for the other 2 methods + toJSON? |
src/interactions/slashCommands/mixins/CommandOptionWithChoices.ts
Outdated
Show resolved
Hide resolved
src/interactions/slashCommands/mixins/CommandOptionWithChoices.ts
Outdated
Show resolved
Hide resolved
src/interactions/slashCommands/mixins/CommandOptionWithChoices.ts
Outdated
Show resolved
Hide resolved
src/interactions/slashCommands/mixins/CommandOptionWithChoices.ts
Outdated
Show resolved
Hide resolved
src/interactions/slashCommands/mixins/CommandOptionWithChoices.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
Any ETA when this will be merged? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
7591598
to
db1cf79
Compare
Please describe the changes this PR makes and why it should be merged:
I figured out the types so I'm back. Adds support for autocompletion.
Status and versioning classification: