Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new interfaces for interaction-related structures #129

Merged
merged 2 commits into from
May 3, 2021
Merged

feat: add new interfaces for interaction-related structures #129

merged 2 commits into from
May 3, 2021

Conversation

vaporoxx
Copy link
Contributor

@vaporoxx vaporoxx commented May 2, 2021

Please describe the changes this PR makes and why it should be merged:

This adds new interfaces for the guild members and channels returned when dealing with interactions. Previously, the extra properties were just added to the base interface, but that way it's harder to import and use them. (This will also be useful for discordjs/discord.js#5448)

@vaporoxx
Copy link
Contributor Author

vaporoxx commented May 3, 2021

@vladfrangu I refactored it a bit so that the interaction member and resolved members do not share the same interface, it would be good if you could have another look

@vladfrangu
Copy link
Member

I mean.. sure, that works too!

@vaporoxx vaporoxx changed the title feat: add APIInteractionChannel and APIInteractionGuildMember feat: add new interfaces for interaction-related structures May 3, 2021
@vladfrangu vladfrangu merged commit bd638b9 into discordjs:main May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants