Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(Enums): make property casing consistent #131

Merged
merged 6 commits into from
May 11, 2021
Merged

refactor(Enums): make property casing consistent #131

merged 6 commits into from
May 11, 2021

Conversation

vaporoxx
Copy link
Contributor

@vaporoxx vaporoxx commented May 7, 2021 •
edited
Loading

Please describe the changes this PR makes and why it should be merged:

This PR converts all enum properties to pascal case for more consistency within the library.

@kyranet kyranet requested review from vladfrangu and kyranet May 7, 2021 17:10
vladfrangu
vladfrangu requested changes May 7, 2021
View reviewed changes
gateway/v8.ts Outdated Show resolved Hide resolved
payloads/v8/channel.ts Outdated Show resolved Hide resolved
payloads/v8/guild.ts Outdated Show resolved Hide resolved
payloads/v8/user.ts Outdated Show resolved Hide resolved
rest/common.ts Outdated Show resolved Hide resolved
@vaporoxx vaporoxx requested a review from vladfrangu May 7, 2021 18:30
vladfrangu
vladfrangu requested changes May 10, 2021
View reviewed changes
payloads/v8/channel.ts Outdated Show resolved Hide resolved
vladfrangu
vladfrangu approved these changes May 10, 2021
View reviewed changes
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me this looks fine. I'd like @kyranet to double check everything too tho

kyranet
kyranet reviewed May 10, 2021
View reviewed changes
Copy link
Member

@kyranet kyranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should PermissionFlagsBits be PascalCase as well? It's not an enum, but it behaves similar to one. cc: @vladfrangu

https://github.com/vaporox/discord-api-types/blob/6dc030fe0cb5f44f15bdb62e738672f5ce50fbab/payloads/v8/permissions.ts#L15-L47

Other than that, there are no more SCREAMING_SNAKE_CASE keys besides v6's values, which are untouched by this PR.

@vladfrangu
Copy link
Member

Should PermissionFlagsBits be PascalCase as well? It's not an enum, but it behaves similar to one. cc: @vladfrangu

vaporox/discord-api-types@6dc030f/payloads/v8/permissions.ts#L15-L47

Other than that, there are no more SCREAMING_SNAKE_CASE keys besides v6's values, which are untouched by this PR.

Yes! @vaporox ^

@vaporoxx
Copy link
Contributor Author

Did that (with some unrelated things I found along the way as well), should the v6 types remain untouched?

@vladfrangu
Copy link
Member

Did that (with some unrelated things I found along the way as well), should the v6 types remain untouched?

v6 is not getting any updates anymore :D

kyranet
kyranet requested changes May 11, 2021
View reviewed changes
deno/gateway/v8.ts Show resolved Hide resolved
@vladfrangu vladfrangu requested a review from iCrawl May 11, 2021 16:21
@vladfrangu vladfrangu changed the title refactor: make enum property casing consistent refactor(Enums): make property casing consistent May 11, 2021
@vladfrangu vladfrangu merged commit aa5e26d into discordjs:main May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

Assignees
No one assigned
Labels
semver:major
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vaporoxx @vladfrangu @iCrawl @kyranet