Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Get up to date *again* #156

Merged
merged 20 commits into from
Jul 19, 2021
Merged

chore: Get up to date *again* #156

merged 20 commits into from
Jul 19, 2021

Conversation

vladfrangu
Copy link
Member

@vladfrangu vladfrangu commented Jul 18, 2021 •
edited
Loading

Please describe the changes this PR makes and why it should be merged:

Draft for now, as I still have lots to do :megu:

  • Updates dependencies
  • Cleans up message buttons, makes them stricter too
  • Brings some oauth2 docs up tod ate
  • Corrects the key for the nick change, it's now ACTUALLY nick instead of what it was previously
  • Adds the missing application_id property to messages
  • Fixes the unversioned API bases in rest exports
  • Adds all new guild features to v9 (and v8 once @advaith1 and I talk)
  • Fixes the rudimentary interactions types, making them stricter and cleaner
  • If you're like me and want to test your unions, tsd is now present, so have at it!

Reference Discord API Docs PRs or commits:

@vladfrangu vladfrangu self-assigned this Jul 18, 2021
@vladfrangu vladfrangu marked this pull request as ready for review July 18, 2021 16:57
@vladfrangu
chore: add support for tsd testing
aa04ac8 
Is this needed? Not really. But can be useful for verifying unions
@vladfrangu
chore: add new features in v8 too
2a25a03 
Confirmation received!
@vladfrangu
chore: add back Guild/DM interactions, but better
0170bbb
@vladfrangu
chore: export appropriate types of DM/Guild interactions
10701a8 
For those that *really* know what data they're getting
monbrey
monbrey suggested changes Jul 19, 2021
View reviewed changes
payloads/v9/_interactions/base.ts Outdated Show resolved Hide resolved
payloads/v9/_interactions/base.ts Outdated Show resolved Hide resolved
payloads/v9/_interactions/base.ts Show resolved Hide resolved
payloads/v9/_interactions/messageComponents.ts Outdated Show resolved Hide resolved
payloads/v9/_interactions/responses.ts Outdated Show resolved Hide resolved
payloads/v9/_interactions/slashCommands.ts Outdated Show resolved Hide resolved
payloads/v9/_interactions/slashCommands.ts Outdated Show resolved Hide resolved
payloads/v9/_interactions/slashCommands.ts Outdated Show resolved Hide resolved
payloads/v9/_interactions/slashCommands.ts Outdated Show resolved Hide resolved
payloads/v9/channel.ts Outdated Show resolved Hide resolved
vladfrangu and others added 5 commits July 19, 2021 13:37
@vladfrangu @monbrey
chore: Apply suggestions from code review
760cf98 
Co-authored-by: monbrey <rsm999@uowmail.edu.au>
@vladfrangu @monbrey
chore: Apply suggestion from code review
fbcc890 
Co-authored-by: monbrey <rsm999@uowmail.edu.au>
@vladfrangu
chore: update v8 with code reviews
5d70d86 
Co-authored-by: monbrey <rsm999@uowmail.edu.au>
@vladfrangu
chore: fix build errors
873048b
@vladfrangu
feat: bring back utility functions
657a456
SpaceEEC
SpaceEEC requested changes Jul 19, 2021
View reviewed changes
Copy link
Member

@SpaceEEC SpaceEEC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have these nits and a comment, otherwise LGTM. 👀
Although I didn't do throughout testing.

tests/v9/interactions.test-d.ts Outdated Show resolved Hide resolved
payloads/v8/channel.ts Outdated Show resolved Hide resolved
payloads/v8/channel.ts Outdated Show resolved Hide resolved
payloads/v9/channel.ts Outdated Show resolved Hide resolved
payloads/v9/channel.ts Outdated Show resolved Hide resolved
@vladfrangu vladfrangu requested a review from SpaceEEC July 19, 2021 13:27
@vladfrangu vladfrangu merged commit 86e0736 into main Jul 19, 2021
@vladfrangu vladfrangu deleted the chores/get-up-to-date-again-and-cleanup branch July 19, 2021 19:00
@advaith1 advaith1 mentioned this pull request Jul 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monbrey monbrey monbrey requested changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl

Assignees

@vladfrangu vladfrangu

Labels
semver:major
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vladfrangu @monbrey @kyranet @SpaceEEC