Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(GatewayIdentifyProperties): rename device to $device #17

Merged
merged 1 commit into from
Sep 19, 2020
Merged

fix(GatewayIdentifyProperties): rename device to $device #17

merged 1 commit into from
Sep 19, 2020

Conversation

NotSugden
Copy link
Contributor

ref: https://discord.com/developers/docs/topics/gateway#identify-identify-connection-properties

the device in GatewayIdentifyProperties should be $device not device

TTtie
TTtie approved these changes Sep 19, 2020
View reviewed changes
Copy link
Contributor

@TTtie TTtie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vladfrangu vladfrangu changed the title fix(GatewayIdentifyProperties): use correct name fix(GatewayIdentifyProperties): rename device to $device Sep 19, 2020
@vladfrangu vladfrangu merged commit 9e5c5b5 into discordjs:main Sep 19, 2020
@github-actions github-actions bot mentioned this pull request Sep 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TTtie TTtie TTtie approved these changes

@vladfrangu vladfrangu vladfrangu approved these changes

@kyranet kyranet kyranet approved these changes

Assignees
No one assigned
Labels
semver:major
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@NotSugden @TTtie @vladfrangu @kyranet