Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(PermissionFlagBits): update thread permissions #181

Merged
merged 2 commits into from
Sep 21, 2021
Merged

feat(PermissionFlagBits): update thread permissions #181

merged 2 commits into from
Sep 21, 2021

Conversation

advaith1
Copy link
Contributor

vladfrangu
vladfrangu approved these changes Aug 18, 2021
View reviewed changes
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could make this sem minor by still providing the old names, with an @deprecated tag, so users in 13.2 or whatever version can use SendMessagesInThread... Nonetheless, LGTM

@vladfrangu
Copy link
Member

Wait. This is -types

@vladfrangu
Copy link
Member

This needs a rebase

@vladfrangu
Copy link
Member

Should we include these in v8 too, even if it doesn't include threads? @advaith1 @discordjs/the-big-3

@ImRodry
Copy link
Contributor

ImRodry commented Sep 19, 2021

I mean the permission bits will still be there on v8 so why not

@advaith1
Copy link
Contributor Author

well all the thread rest stuff and permissions are in API v8 too, but we don't include them so 🤷‍♂️

@vladfrangu
Copy link
Member

Honestly I'm considering just.. moving permission bit fields to common.ts since they're the same across API versions

@discordjs discordjs deleted a comment Sep 21, 2021
@discordjs discordjs deleted a comment Sep 21, 2021
@vladfrangu vladfrangu merged commit 68d97ae into discordjs:main Sep 21, 2021
@advaith1 advaith1 deleted the thread-permission-updates branch September 26, 2021 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@moritz-mn moritz-mn moritz-mn approved these changes

Assignees
No one assigned
Labels
semver:major
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@advaith1 @vladfrangu @ImRodry @iCrawl @kyranet @moritz-mn