Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Routes): add missing OAuth2 routes #218

Merged
merged 3 commits into from
Oct 9, 2021
Merged

feat(Routes): add missing OAuth2 routes #218

merged 3 commits into from
Oct 9, 2021

Conversation

MattIPv4
Copy link
Contributor

@MattIPv4 MattIPv4 commented Oct 9, 2021

Please describe the changes this PR makes and why it should be merged:

The OAuth2 token flow routes are currently only available in OAuth2Routes, but these are already prefixed with the API base, which makes them inconsistent with all the other route helpers. This PR adds the OAuth2 token flow routes to the main Routes object in a consistent format with all other routes.

This PR does not remove them from OAuth2Routes, to ensure that this is a non-breaking change.

Reference Discord API Docs PRs or commits:

https://discord.com/developers/docs/topics/oauth2

@MattIPv4
Copy link
Contributor Author

MattIPv4 commented Oct 9, 2021

I guess one could also consider this chore rather than feat, dealers choice ig.

@vladfrangu vladfrangu changed the title feat(rest/Routes): add missing OAuth2 routes to Routes feat(Routes): add missing OAuth2 routes to Routes Oct 9, 2021
@vladfrangu vladfrangu changed the title feat(Routes): add missing OAuth2 routes to Routes feat(Routes): add missing OAuth2 routes Oct 9, 2021
@vladfrangu vladfrangu merged commit 9dd3446 into discordjs:main Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants