fix(RESTPostAPIGuildsJSONBody): use correct types #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladfrangu
requested changes
Oct 1, 2020
vladfrangu
requested changes
Oct 2, 2020
vladfrangu
approved these changes
Oct 2, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on the API docs for Create Guild (POST /guilds) there are a couple of info boxes stating that roles and channels can have an integer ID as a placeholder, eg for creating channel overwrites, this PR corrects these types into numbers
This PR also corrects the type for
rolesinRESTPostAPIGuildsJSONBodyas it was previously typed asAPIRolewhich isn't technically correct; the API won't accept permissons_new here,afk_channel_idandsystem_channel_idare documented to be of type snowflake, but testing shows that the API accepts an integer, (there is an issue on the API about this discord/discord-api-docs#2089)also i think these types need better names perhaps? im really not good with names so if anyones got suggestions