Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct types for REST attachments #238

Merged
merged 4 commits into from
Nov 17, 2021
Merged

fix: correct types for REST attachments #238

merged 4 commits into from
Nov 17, 2021

Conversation

gc
Copy link
Contributor

@gc gc commented Nov 17, 2021

It seem like these types are doing this:

attachments: (object) & (object[])

instead of

attachments: (object & object)[]

typescript playground link to demonstrate

@vladfrangu vladfrangu changed the title fix: correct types for attachments fix: correct types for REST attachments Nov 17, 2021
@vladfrangu vladfrangu merged commit fa54b9d into discordjs:main Nov 17, 2021
@gc gc deleted the patch-1 branch November 17, 2021 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gc @vladfrangu