Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(GatewayPresence): correct type for sent activity objects #30

Merged
merged 2 commits into from
Oct 18, 2020
Merged

fix(GatewayPresence): correct type for sent activity objects #30

merged 2 commits into from
Oct 18, 2020

Conversation

vaporoxx
Copy link
Contributor

API Docs: Bots are only able to send name, type, and optionally url.

There is no separation between activity objects received from Discord and ones sent from the client. That causes problems like this, even though created_at should not be sent / will be ignored anyway.

image

I'm not fully familiar with the file structure yet, so if I placed it where it doesn't belong just let me know.

Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll get it right eventually:tm:

curse you Discord with confusing types

@vladfrangu vladfrangu changed the title fix(GatewayPresence): add new type for sent activity objects fix(GatewayPresence): correct type for sent activity objects Oct 18, 2020
@vladfrangu vladfrangu merged commit 61db1ee into discordjs:main Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants