Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(APIApplicationCommand): add command localization #370

Merged
merged 2 commits into from Mar 23, 2022

Conversation

suneettipirneni
Copy link
Member

Please describe the changes this PR makes and why it should be merged:

If applicable, please reference Discord API Docs PRs or commits that influenced this PR:

@suneettipirneni suneettipirneni changed the title feat(interactions): add interaction localization feat: add slash command localization Mar 17, 2022
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also make sure rest types work fine with this

@suneettipirneni
Copy link
Member Author

Upstream PR landed

@vladfrangu vladfrangu changed the title feat: add slash command localization feat(APIApplicationCommand): add command localization Mar 23, 2022
@vladfrangu vladfrangu merged commit f702988 into discordjs:main Mar 23, 2022
@suneettipirneni suneettipirneni deleted the feat/localizations branch March 23, 2022 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants