-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for application command permissions v2 #415
Merged
vladfrangu
merged 12 commits into
discordjs:main
from
suneettipirneni:feat/permissions-v2
May 12, 2022
Merged
feat: add support for application command permissions v2 #415
vladfrangu
merged 12 commits into
discordjs:main
from
suneettipirneni:feat/permissions-v2
May 12, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladfrangu
requested changes
Apr 28, 2022
deno/payloads/v10/_interactions/_applicationCommands/permissions.ts
Outdated
Show resolved
Hide resolved
Should also track discord/discord-api-docs#4836 and discord/discord-api-docs#4833 |
ckohen
reviewed
Apr 28, 2022
vvito7
reviewed
Apr 28, 2022
deno/payloads/v10/_interactions/_applicationCommands/permissions.ts
Outdated
Show resolved
Hide resolved
About #415 (comment), more one to track discord/discord-api-docs#4845 |
9 tasks
f3831b7
to
6505649
Compare
ckohen
reviewed
May 1, 2022
vladfrangu
requested changes
May 1, 2022
vladfrangu
requested changes
May 12, 2022
deno/payloads/v9/_interactions/_applicationCommands/permissions.ts
Outdated
Show resolved
Hide resolved
vladfrangu
requested changes
May 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
final requests i swear
vladfrangu
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Credit to @Vitorlops for making the basis for this PR.
If applicable, please reference Discord API Docs PRs or commits that influenced this PR:
applications.commands.permissions.update
scope description discord/discord-api-docs#4833