-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: separate MESSAGE_CREATE
fields from APIMessage
object
#434
refactor: separate MESSAGE_CREATE
fields from APIMessage
object
#434
Conversation
Can you ensure the PR is up to date with the upstream PM? Let me know, and I'll merge it |
What do you think of transforming this (extra fields): /**
* ID of the guild the message was sent in
*/
guild_id?: Snowflake;
/**
* Member properties for this message's author
*
* The member object exists in `MESSAGE_CREATE` and `MESSAGE_UPDATE` events
* from text-based guild channels
*
* See https://discord.com/developers/docs/resources/guild#guild-member-object
*/
member?: APIGuildMember;
/**
* Users specifically mentioned in the message
*
* The `member` field is only present in `MESSAGE_CREATE` and `MESSAGE_UPDATE` events
* from text-based guild channels
*
* See https://discord.com/developers/docs/resources/user#user-object
* See https://discord.com/developers/docs/resources/guild#guild-member-object
*/
mentions: (APIUser & { member?: Omit<APIGuildMember, 'user'> })[]; into an interface? Since we are using it twice, in the create and update event. And also, should this kind of comment "The member object exists in |
@vvito7 is attempting to deploy a commit to the Sapphire Team on Vercel. A member of the Team first needs to authorize it. |
sure
Sure |
Hopefully everything is ok now |
MESSAGE_CREATE
fields from APIMessage
objectMESSAGE_CREATE
fields from APIMessage
object
Please describe the changes this PR makes and why it should be merged:
Separates
MESSAGE_CREATE
andMESSAGE_UPDATE
fields fromAPIMessage
object.If applicable, please reference Discord API Docs PRs or commits that influenced this PR: