feat(APIVoiceChannel): support text in voice, properties last_message_id and rate_limit_per_user
#544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
requested review from
iCrawl,
kyranet,
SpaceEEC and
vladfrangu
vladfrangu
requested changes
Aug 3, 2022
vladfrangu
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Adds the missing properties to
APIVoiceChannel(last_message_idandrate_limit_per_user) which were now included in the voice channel payload, with the "Text In Voice" feature, making it a text-based channel.But to make it more dynamic takes
APIVoiceChannelas a base with the common properties in the voice channel types (Now it will beAPIVoiceChannelBase) because a guild contains two types of voice channels:GUILD_VOICEandGUILD_STAGE_VOICE.So, this PR:
Creates a type called
APIGuildStageVoiceChannel, which covers the channel with theGUILD_STAGE_VOICEtype.Adds
rate_limit_per_userproperty toAPITextBasedChannel(it already had thelast_message_idproperty).Creates an interface called
APIGuildVoiceChannel, which covers the channel with theGUILD_VOICEtype, usingAPIVoiceChannelBaseandAPITextBasedChannel, adding thevideo_quality_modeproperty.If applicable, please reference Discord API Docs PRs or commits that influenced this PR: