New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add common JSON error types #568
Merged
vladfrangu
merged 7 commits into
discordjs:main
from
promise:add-common-json-error-types
Aug 19, 2022
Merged
feat: add common JSON error types #568
vladfrangu
merged 7 commits into
discordjs:main
from
promise:add-common-json-error-types
Aug 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
requested review from
iCrawl,
kyranet,
SpaceEEC and
vladfrangu
August 19, 2022 09:49
vladfrangu
requested changes
Aug 19, 2022
promise
requested review from
vladfrangu
and removed request for
iCrawl,
kyranet and
SpaceEEC
August 19, 2022 13:49
vladfrangu
requested changes
Aug 19, 2022
vladfrangu
approved these changes
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Adds common JSON error types from discordjs/rest. Should be merged because there's currently no error types.
If applicable, please reference Discord API Docs PRs or commits that influenced this PR:
https://github.com/discordjs/discord.js/blob/e475b63f257f6261d73cb89fee9ecbcdd84e2a6b/packages/rest/src/lib/errors/DiscordAPIError.ts#L3-L18
https://discord.com/developers/docs/topics/opcodes-and-status-codes#json