Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ApplicationCommand): export base chat input types #569

Merged
merged 4 commits into from Aug 19, 2022

Conversation

IanMitchell
Copy link
Member

Please describe the changes this PR makes and why it should be merged:
Allows for importing helpful types like APIApplicationCommandOptionBase (less helpful for applications, very helpful for libraries)

If applicable, please reference Discord API Docs PRs or commits that influenced this PR:
N/A

@vercel
Copy link

vercel bot commented Aug 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-api-types ❌ Failed (Inspect) Aug 19, 2022 at 7:23PM (UTC)

Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v9 too! 🙏

@IanMitchell
Copy link
Member Author

Done

@vladfrangu
Copy link
Member

Hey @IanMitchell! Taking a look at commit fa34b66, it seems that you forgot to run npm run build:deno. Here are the files that are different from the base:

Please run npm run build:deno and commit the results to update the deno types.

@vladfrangu vladfrangu changed the title feat(ApplicationCommand): Export base chat input types feat(ApplicationCommand): export base chat input types Aug 19, 2022
@vladfrangu vladfrangu merged commit 248484e into discordjs:main Aug 19, 2022
@IanMitchell IanMitchell deleted the export-base-types branch August 19, 2022 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants