Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RESTPostAPIChannelMessageJSONBody): number for attachment ids #811

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Aug 22, 2023

Please describe the changes this PR makes and why it should be merged:
ids in the attachments array should also be typed as numbers to match files[n], if necessary.

If applicable, please reference Discord API Docs PRs or commits that influenced this PR:
https://discord.com/developers/docs/reference#uploading-files

@vercel
Copy link

vercel bot commented Aug 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-api-types ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2023 2:36pm

vladfrangu
vladfrangu previously approved these changes Aug 22, 2023
SpaceEEC
SpaceEEC previously approved these changes Aug 22, 2023
@Jiralite Jiralite dismissed stale reviews from SpaceEEC and vladfrangu via 2940ee8 August 22, 2023 14:22
@Jiralite Jiralite requested review from a team as code owners August 22, 2023 14:22
@vladfrangu vladfrangu merged commit 1eb0161 into main Aug 24, 2023
8 checks passed
@vladfrangu vladfrangu deleted the fix/number-attachment-id branch August 24, 2023 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants