Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(GatewayThreadDispatch): properly type thread create/update/delete dispatches #861

Merged
merged 3 commits into from
Dec 27, 2023

Conversation

Saghetti0
Copy link
Contributor

Closes #860

Copy link

vercel bot commented Dec 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-api-types ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2023 11:30am

@vladfrangu
Copy link
Member

Please run npm run clean and then re-build deno types

@Saghetti0
Copy link
Contributor Author

Done, code now builds successfully and passes tests.

Jiralite
Jiralite previously approved these changes Dec 27, 2023
deno/gateway/v10.ts Show resolved Hide resolved
@vladfrangu
Copy link
Member

Can you re-export GatewayThreadModifyDispatch as a deprecated type? Otherwise this is a breaking change

@Saghetti0
Copy link
Contributor Author

Alright, I added it back and put in a deprecation notice

@vladfrangu vladfrangu merged commit 819d852 into discordjs:main Dec 27, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken types for thread events
4 participants