Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added userID property to Presence class #4013

Merged
merged 2 commits into from
Apr 3, 2020
Merged

Added userID property to Presence class #4013

merged 2 commits into from
Apr 3, 2020

Conversation

Syntle
Copy link
Contributor

@Syntle Syntle commented Apr 1, 2020

userID property exists in docs but not in typings

Please describe the changes this PR makes and why it should be merged:

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@Syntle
Added userID property to Presence class
a6bddd6 
userID property exists in docs but not in typings
RDambrosio016
RDambrosio016 suggested changes Apr 1, 2020
View reviewed changes
typings/index.d.ts Outdated Show resolved Hide resolved
qwright10
qwright10 approved these changes Apr 1, 2020
View reviewed changes
Copy link
Contributor

@qwright10 qwright10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SpaceEEC @RDambrosio016
fix(Presence): userID should be typed as Snowflake
872ec8a 
Co-Authored-By: BorgerKing <38166539+RDambrosio016@users.noreply.github.com>
@SpaceEEC SpaceEEC merged commit 691e96c into discordjs:master Apr 3, 2020
@snyk-bot snyk-bot mentioned this pull request Apr 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RDambrosio016 RDambrosio016 RDambrosio016 requested changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@qwright10 qwright10 qwright10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Syntle @SpaceEEC @RDambrosio016 @qwright10