Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Guild): sort text, news, and store channels together #4070

Merged
merged 1 commit into from
Apr 16, 2020
Merged

fix(Guild): sort text, news, and store channels together #4070

merged 1 commit into from
Apr 16, 2020

Conversation

advaith1
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
This PR sorts text, news, and store channels together, and fixes the positions of those channels. Fixes #3963.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@iCrawl iCrawl merged commit fcacf1b into discordjs:master Apr 16, 2020
@snyk-bot snyk-bot mentioned this pull request Apr 28, 2020
Merged
@advaith1 advaith1 deleted the position-fix branch August 12, 2020 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iCrawl iCrawl iCrawl approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Positions for text, announcement, and store channels are all separate
3 participants
@advaith1 @iCrawl @SpaceEEC