Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ClientOptions): allow setting default allowedMentions #4085

Merged
merged 6 commits into from
Apr 17, 2020

Conversation

monbrey
Copy link
Member

@monbrey monbrey commented Apr 15, 2020

This PR adds the ability to set ClientOptions#allowedMentions to be used as a default whenever MessageOptions#allowedMentions is not provided.

If not provided as an option, the default behaviour by Discord is to parse all mentions.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@monbrey monbrey changed the title feat(ClientOptions): default allowedMentions values feat(ClientOptions): allowe setting default allowedMentions Apr 15, 2020
@monbrey monbrey changed the title feat(ClientOptions): allowe setting default allowedMentions feat(ClientOptions): allow setting default allowedMentions Apr 15, 2020
Copy link
Member

@SpaceEEC SpaceEEC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nits.

src/util/Constants.js Outdated Show resolved Hide resolved
src/util/Constants.js Outdated Show resolved Hide resolved
src/structures/APIMessage.js Outdated Show resolved Hide resolved
src/structures/APIMessage.js Outdated Show resolved Hide resolved
@iCrawl iCrawl requested a review from SpaceEEC April 17, 2020 07:39
@iCrawl iCrawl merged commit 7c6000c into discordjs:master Apr 17, 2020
@monbrey monbrey deleted the allowed-mentions branch October 1, 2020 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants