Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Guild): change wrong description & call fetchVanityData internally #4335

Merged
merged 3 commits into from Jun 4, 2020

Conversation

papaia
Copy link
Contributor

@papaia papaia commented Jun 4, 2020

Please describe the changes this PR makes and why it should be merged:
The docs for vanityURLUses mention the need to use Guild#fetchVanityCode (and not Guild#fetchVanityData), which is wrong.
Also, this PR makes it that even when only calling fetchVanityCode, it will internally call fetchVanityData, so the users would be set anyway.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.
    This PR includes internal code changes as well as documentation changes.

src/structures/Guild.js Outdated Show resolved Hide resolved
@SpaceEEC SpaceEEC merged commit 1c275af into discordjs:master Jun 4, 2020
@papaia papaia deleted the feat/better-vanity branch June 4, 2020 17:20
@papaia papaia restored the feat/better-vanity branch June 4, 2020 17:20
@papaia papaia deleted the feat/better-vanity branch June 4, 2020 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants