Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ActivityTypes): add Competing (type 5) #4824

Merged
merged 1 commit into from
Sep 15, 2020
Merged

feat(ActivityTypes): add Competing (type 5) #4824

merged 1 commit into from
Sep 15, 2020

Conversation

advaith1
Copy link
Contributor

@advaith1 advaith1 commented Sep 15, 2020 •
edited
Loading

Please describe the changes this PR makes and why it should be merged:
Adds activity type 5, Competing (discord/discord-api-docs@cd6c72a)

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@iCrawl iCrawl merged commit 9c76129 into discordjs:master Sep 15, 2020
@advaith1 advaith1 deleted the competing branch September 15, 2020 20:15
GiorgioBrux pushed a commit to GiorgioBrux/discord.js that referenced this pull request Oct 1, 2020
@advaith1 @GiorgioBrux
feat(ActivityTypes): add Competing (type 5) (discordjs#4824)
145d49d
GiorgioBrux pushed a commit to GiorgioBrux/discord.js that referenced this pull request Oct 17, 2020
@advaith1 @GiorgioBrux
feat(ActivityTypes): add Competing (type 5) (discordjs#4824)
1414408
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@advaith1 @vladfrangu @iCrawl @kyranet