Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Action): Sanity-Check if Discord includes all required data #4841

Merged
merged 1 commit into from
Sep 25, 2020

Conversation

wasdennnoch
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:

Fixes #4840
I would've expected Discord to alyways include both a guild_id and a member if the event came from a guild but - guess not.
Make sure that the fields we are interested in are actually present in the payload.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@iCrawl iCrawl merged commit 4e79e39 into discordjs:master Sep 25, 2020
GiorgioBrux pushed a commit to GiorgioBrux/discord.js that referenced this pull request Oct 1, 2020
GiorgioBrux pushed a commit to GiorgioBrux/discord.js that referenced this pull request Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError on MESSAGE_REACTION_ADD
5 participants