Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(User): only assign to bot initially or if info is actually present #4990

Merged
merged 1 commit into from
Nov 20, 2020

Conversation

SpaceEEC
Copy link
Member

@SpaceEEC SpaceEEC commented Nov 8, 2020

Please describe the changes this PR makes and why it should be merged:

Fixes #4985 and fixes #4943.

This PR fixes the bot property of a bot to erroneously changing into false when the USER partial was enabled and their partial is requested through something like Action#getUser or explicitly through UserStore#add with just an id property.

This is solved by only initially setting the property, or updating it if the payload actually includes a bot property

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

src/structures/User.js Show resolved Hide resolved
@iCrawl iCrawl merged commit eaecd0e into discordjs:master Nov 20, 2020
@advaith1
Copy link
Contributor

Shouldn't this also be done for User#system?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants