Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MessageReaction): defines the client property in the type #5003

Merged
merged 1 commit into from Nov 17, 2020
Merged

fix(MessageReaction): defines the client property in the type #5003

merged 1 commit into from Nov 17, 2020

Conversation

itsa-sh
Copy link
Contributor

@itsa-sh itsa-sh commented Nov 10, 2020

Please describe the changes this PR makes and why it should be merged:

I created an issue #5002 this is the PR to resolve it. I wasn't 100% sure i've followed the contribution guidelines.

This solves the missing client property from the MessageReaction typing

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@@ -1167,6 +1167,7 @@ declare module 'discord.js' {

public count: number | null;
public readonly emoji: GuildEmoji | ReactionEmoji;
public readonly client: Client;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be above count, to be sorted alphabetically

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, I'll update in the morning :)

@SpaceEEC SpaceEEC linked an issue Nov 11, 2020 that may be closed by this pull request
1 task
Copy link
Member

@kyranet kyranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the property exists in the JS code.

/**
* The client that instantiated this message reaction
* @name MessageReaction#client
* @type {Client}
* @readonly
*/
Object.defineProperty(this, 'client', { value: client });

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing typing for MessageReaction
7 participants