New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(MessageReaction): defines the client property in the type #5003
Conversation
typings/index.d.ts
Outdated
@@ -1167,6 +1167,7 @@ declare module 'discord.js' { | |||
|
|||
public count: number | null; | |||
public readonly emoji: GuildEmoji | ReactionEmoji; | |||
public readonly client: Client; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be above count
, to be sorted alphabetically
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries, I'll update in the morning :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the property exists in the JS code.
discord.js/src/structures/MessageReaction.js
Lines 18 to 24 in b8fd3f6
/** | |
* The client that instantiated this message reaction | |
* @name MessageReaction#client | |
* @type {Client} | |
* @readonly | |
*/ | |
Object.defineProperty(this, 'client', { value: client }); |
Please describe the changes this PR makes and why it should be merged:
I created an issue #5002 this is the PR to resolve it. I wasn't 100% sure i've followed the contribution guidelines.
This solves the missing
client
property from theMessageReaction
typingStatus
Semantic versioning classification: