Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VoiceConnection): make #dispatcher nullable #5217

Merged
merged 1 commit into from
Jan 22, 2021
Merged

fix(VoiceConnection): make #dispatcher nullable #5217

merged 1 commit into from
Jan 22, 2021

Conversation

iShibi
Copy link
Contributor

@iShibi iShibi commented Jan 16, 2021

Please describe the changes this PR makes and why it should be merged:

fixes: #5205
The dispatcher property of VoiceConnection is marked as nullable in docs but only got StreamDispatcher as its type in typings. This PR fixes it.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@iCrawl iCrawl merged commit 0d5de43 into discordjs:master Jan 22, 2021
@iShibi iShibi deleted the fix-5205 branch February 1, 2021 12:16
@iCrawl iCrawl added this to the Version 13 milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typings: VoiceConnection.dispatcher has wrong type
5 participants