Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Webhook): add 'fetchMessage' method #5530

Merged
merged 2 commits into from
Apr 30, 2021

Conversation

izexi
Copy link
Contributor

@izexi izexi commented Apr 14, 2021

Ref: discord/discord-api-docs#2812
This PR will be marked as draft until the referenced PR above has been merged.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@ThaTiemsz
Copy link
Contributor

has been merged now in discord/discord-api-docs@94d57ea. On a side note, shouldn't the jsdocs/typings for the method also accept a string since @original is also accepted as parameter?

@izexi izexi marked this pull request as ready for review April 15, 2021 08:45
@izexi
Copy link
Contributor Author

izexi commented Apr 15, 2021

has been merged now in discord/discord-api-docs@94d57ea. On a side note, shouldn't the jsdocs/typings for the method also accept a string since @original is also accepted as parameter?

Although Snowflake is currently typed as a string and passing @original would work, I do agree that it would be nicer to have a union type that also accepts @original as a string literal and or a JSDoc info tag along with that.

I was going to comment on this to be added in #5448 after this PR has been merged, since I think its more within the scope of that PR (and the same will need to be done on Webhook#editMessage/deleteMessage()).

@izexi izexi force-pushed the feat/Webhook#fetchMessage() branch from 3f20c90 to 08d8278 Compare April 23, 2021 16:48
@izexi izexi mentioned this pull request Apr 23, 2021
@iCrawl iCrawl merged commit 63398d6 into discordjs:master Apr 30, 2021
@izexi izexi deleted the feat/Webhook#fetchMessage() branch April 30, 2021 20:01
@iCrawl iCrawl added this to the Version 13 milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants