Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ButtonComponent#disabled is null when it should be false #8964

Closed
ImRodry opened this issue Dec 22, 2022 · 0 comments · Fixed by #8965
Closed

ButtonComponent#disabled is null when it should be false #8964

ImRodry opened this issue Dec 22, 2022 · 0 comments · Fixed by #8965

Comments

@ImRodry
Copy link
Contributor

ImRodry commented Dec 22, 2022

Which package is this bug report for?

discord.js

Issue description

It seems like Discord doesn't send the disabled param when a button is enabled so ButtonComponent#disabled should default to false instead of null on this line:

return this.data.disabled ?? null;

I'm only mentioning buttons because I only tested this with them but I assume the same applies to other components

Code sample

No response

Package version

14.7.1

Node.js version

18.12.1

Operating system

Windows 11

Priority this issue should have

Low (slightly annoying)

Which partials do you have configured?

Not applicable (subpackage bug)

Which gateway intents are you subscribing to?

Not applicable (subpackage bug)

I have tested this issue on a development release

No response

@kodiakhq kodiakhq bot closed this as completed in #8965 Dec 24, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants