Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing error for reactions #8968

Closed
DraftProducts opened this issue Dec 24, 2022 · 1 comment · Fixed by #8969
Closed

Typing error for reactions #8968

DraftProducts opened this issue Dec 24, 2022 · 1 comment · Fixed by #8969

Comments

@DraftProducts
Copy link
Contributor

DraftProducts commented Dec 24, 2022

Which package is this bug report for?

discord.js

Issue description

In the #5717 PR were added some additional typings for MessageReactionResolvable.
image

There is actually no code that can parse it in the MessageReactionManager>.resolve() (there is no override of the <DataManager>.resolve()).
A string is not an instance of MessageReaction, and those formulations are not indexes of Collection cached reactions (id or name).

Package version

dev

Priority this issue should have

Medium (should be fixed soon)

I have tested this issue on a development release

22e2bbb

@Jiralite
Copy link
Member

A string is not an instance of MessageReaction

This is not correct. Unicode emojis!

It looks like MessageReactionResolvable is used by the reaction manager and nowhere else. It actually looks like EmojiIdentifierResolvable should have these string variants, but is loosely typed as a string.

@Jiralite Jiralite self-assigned this Dec 25, 2022
@kodiakhq kodiakhq bot closed this as completed in #8969 Dec 31, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants