Install fails with github actions

[iwa]

Please describe the problem you are having in as much detail as possible:
node-pre-gyp not found when installing the package on Github Actions

Include a reproducible code sample here, if possible:

yarn install v1.22.4
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
[4/4] Building fresh packages...
error /home/runner/work/Q-Bot/Q-Bot/node_modules/@discordjs/opus: Command failed.
Exit code: 1
Command: patch-package && node-pre-gyp install --fallback-to-build
Arguments: 
Directory: /home/runner/work/Q-Bot/Q-Bot/node_modules/@discordjs/opus
Output:
patch-package 6.2.2
Applying patches...
Error: Patch file found for package node-pre-gyp which is not present at node_modules/node-pre-gyp
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
##[error]Process completed with exit code 1.

Further details:

• @discordjs/opus version: 0.2.1
• Node.js version: v12
• Operating system: ubuntu-latest
• Priority this issue should have – please be realistic and elaborate if possible: Not that much important, but still annoying (might be my fault with my CI config)

[iCrawl]

That seems like a yarn issue, can you try npm?

[iwa]

still not working 🤔

my ci config file is available here (if needed) : https://github.com/iwaQwQ/Q-Bot/blob/feature/ci-update/.github/workflows/ci.yml

[iCrawl]

• What is --only=dev such an option does not exist
• Why do you run sudo yarn global add typescript and sudo yarn global add eslint and not have it be a build script?
• Why is @discordjs/opus a devDep? https://github.com/iwaQwQ/Q-Bot/blob/feature/ci-update/package.json#L21

[iwa]

I'm still a newbie with Github Actions, so I may have made some dumb mistakes, sorry about that
I learnt CI configs with Gitlab, so i'm used to write the entire script on my own

I put every needed dependencies into devDep because I run multiple bots on my server, so instead of having to install libsodium for each bot, i've installed it globally.
Like that i don't have to install it on my pc or CIs host since i can install only dev dependencies with --only=dev.
But I think doing that is a mistake ?

[iCrawl]

Yeah, sadly thats not how things work in node.

Every package.json should list all the things it needs, otherwise we cant guarantee working conditions on packages, like the issue you have right now

[iwa]

Alrighty, thanks for the advice, I'll try again with the corrected list then

[iwa]

Alright, I've fixed my dependencies list, but it was still not working
After some tests, I figured out that it works by installing the dependencies with sudo rights (works both with npm and yarn as long as they have sudo rights)

The issue seems to be only on Github Actions, I tried to install the package on my mac (macOS 10.15.4) and my server, which runs on Debian 10, and everything worked well

Anyway, thanks for your help c:

I had another question, should I also install ffmpeg as a node dependency, or keeping it installed systemwide is fine ?

[iCrawl]

I figured out that it works by installing the dependencies with sudo rights

Using npm i --unsafe-perm usually does the trick here, no idea about yarn on that one though

I had another question, should I also install ffmpeg as a node dependency, or keeping it installed systemwide is fine ?

ffmpeg should be installed via the package manager of the distro you use whether that be brew, apt, pacman, dnf, yum etc. (on windows it should be https://ffmpeg.zeranoe.com/builds/)

[iwa]

yarn don't seems to have a similar option, so I think it only works with sudo rights when using yarn

i'm closing the issue since it's fixed, thanks for your help!