Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You didn't update it to support macOS ARM64, instead you deleted a header file, from what I see. #98

Closed
StupidRepo opened this issue Aug 16, 2021 · 10 comments
Labels
duplicate This issue or pull request already exists

Comments

@StupidRepo
Copy link

Please describe the problem you are having in as much detail as possible:

I literally cannot npm i @discordjs/opus. It gives me a missing header error.

I am on an M1 MacBook Pro.

Include a reproducible code sample here, if possible:

// Place your code here

Further details:

npm ERR! gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
npm ERR! In file included from ../deps/opus/src/opus_decoder.c:50:
npm ERR! In file included from ../deps/opus/silk/structs.h:32:
npm ERR! In file included from ../deps/opus/silk/SigProc_FIX.h:51:
npm ERR! ../deps/opus/silk/arm/biquad_alt_arm.h:31:11: fatal error: 'celt/arm/armcpu.h' file not found
npm ERR! # include "celt/arm/armcpu.h"
npm ERR!           ^~~~~~~~~~~~~~~~~~~
npm ERR! 1 error generated.
npm ERR! make: *** [Release/obj.target/libopus/deps/opus/src/opus_decoder.o] Error 1
  • @discordjs/opus version: none lol
  • Node.js version: 16.6.2
  • Operating system: macOS 11 - ARM
  • Priority this issue should have – please be realistic and elaborate if possible: SUPER HIGH! (For the Mac Users)
@StupidRepo StupidRepo added the bug Something isn't working label Aug 16, 2021
@kyranet
Copy link
Member

kyranet commented Aug 16, 2021

cc: @Androz2091

@StupidRepo
Copy link
Author

What do you mean by "cc: @Androz2091"?

@Androz2091
Copy link
Sponsor Contributor

I am using a Mac Mini m1. It worked when creating an empty project and using npm install. I can try again by clearing the cache maybe? If you have any other idea please let me know

@kyranet
Copy link
Member

kyranet commented Aug 16, 2021

"cc" means Carbon Copy, the same as e-mails, and is used in GitHub to bring somebody's attention.

The PR #97 is what made this change in MacOS ARM64 compatibility, so I just mentioned the author. I hope that helps understanding that @StupidRepo

@StupidRepo
Copy link
Author

Ah ok

@StupidRepo
Copy link
Author

So do we have a general idea why this isn't working?

@kevinbioj
Copy link

kevinbioj commented Aug 16, 2021

There is no issue with the code, it's just that the fix hasn't been released yet. @discordjs/opus on npm does not include #97, so wait for the next release or install it from this repository npm i discordjs/opus.

It compiles perfectly on a M1 MBA on Big Sur 11.5.2, but from the repository source code and not npm.

@kyranet
Copy link
Member

kyranet commented Aug 18, 2021

https://github.com/discordjs/opus/releases/tag/v0.6.0 has been released, please update at your earliest convenience 👍🏼

Edit: Marked this as duplicate of #72.

@kyranet kyranet closed this as completed Aug 18, 2021
@kyranet kyranet added duplicate This issue or pull request already exists and removed bug Something isn't working labels Aug 18, 2021
@StupidRepo
Copy link
Author

Thanks! Will update now

@StupidRepo
Copy link
Author

Holy crap thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

4 participants