Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Buffering state is never actually entered #97

Closed
amishshah opened this issue Apr 5, 2021 · 0 comments · Fixed by #98
Closed

Buffering state is never actually entered #97

amishshah opened this issue Apr 5, 2021 · 0 comments · Fixed by #98
Labels
bug Something isn't working
Projects
Initial Release

Comments

@amishshah
Copy link
Member

I assumed that Readable.readable was synonymous with the readable event, which is emitted when there is data to be read from the stream. Instead, Readable.readable actually means that the stream has not been destroyed or emitted 'error' or 'end'.

AudioPlayer should be updated to check for this properly.
@amishshah amishshah added the bug Something isn't working label Apr 5, 2021
@amishshah amishshah added this to To do in Initial Release via automation Apr 5, 2021
@amishshah amishshah mentioned this issue Apr 7, 2021
Merged
Initial Release automation moved this from To do to Done Apr 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Initial Release
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(AudioPlayer): enter Buffering state for resources that are not yet readable discordjs/voice
1 participant
@amishshah