Initial allowed_mentions implementation #708
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also closes #693, as the temporary message methods are given the same capabilities as the non temporary counter parts |
swarley
force-pushed
the
allowed_mentions
branch
from
ba4e4e7
to
ebaca68
Compare
|
This was merged (with changes) via shardlab/discordrb@e53db8a in the new repo and released in v3.4.0 and can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds
allowed_mentionsoption to message sending methods.Closes #704
Changed
The following methods had the
allowed_mentionsargument addedAPI::Channel.create_messageBot#send_messageBot#send_temporary_messageChannel#send_messageChannel#send_temporary_messageEvents::MessageEvent#send_messageChannel#send_embed- addedttsandallowed_mentionsargumentsEvents::MessageEvent#send_embed- addedttsandallowed_mentionsargumentsEvents::MessageEvent#send_temporary_message- addedtts,embed, andallowed_mentionsarguments.Doc strings need input, I couldn't think of a clean way to DRY across these methods