-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The -c option behaves differently to Linux #10
Comments
Great, I'll see how they're executing. I was a little afraid of entering n levels of encoding hell, so I just pass arguments along to I'm not sure I agree that linux-utils behaviour is what is most reasonable, but compatibility trumps sanity, right? |
Ah, they're being "smart" and passing along to a subshell: https://github.com/karelzak/util-linux/blob/master/sys-utils/flock.c#L239 Can you find one other person to agree this is the appropriate behaviour? I'm torn. |
Looks like it was added back in util-linux/util-linux@baf39af#diff-1219b3b65dcec8078370f245769671b1R193 And the only explanation in its NEWS is:
|
maybe if it's a single string, pass to a subshell; if it's multiple, exec directly? I feel like something has similar behaviour but I can't remember what. |
Thanks for looking into this. I think the
vs
In the first case above, the output of |
ah, well that use case convinces me. I'd usually this pattern for that use case, but that's obnoxious for one-offs. ok, I'll look into implementing this. |
+1 |
so sorry, I dropped this right on the floor. I know I can't get to this till at least this evening, so here are my notes: At the moment, cmd_argv = &argv[optind + 1]; and tossing it straight into if (0 != execvp(cmd_argv[0], cmd_argv)) { so I really just want to build a new Needs doc, especially to say that you can |
Yes, please implement this, it prevents it from being a 'drop in replacement' with some scripts i have :( |
If this is interesting to you, please review the implementation in #23 |
First of all, thanks for this project. It's great! ⭐️
On Linux,
flock(1)
will only accept a single string argument as the-c
argument. This does not work withdiscoteq/flock
:Linux:
macOS:
Interestingly, BusyBox also fails:
Version:
The text was updated successfully, but these errors were encountered: