following category on the category page

[Catrin]

I added a dropdown button on the category page where a logged in user can change the notification level of the category.

[discoursebot]

Thanks for contributing this pull request! Could you please sign our CLA so we can review it? http://www.discourse.org/cla

[SamSaffron]

very interesting, we always wanted something like this. what happens by default here? looks like the drop down only has overrides?

[Catrin]

Just like the topic-notification-button the default ist "regular", but there is no possibility to remove the notification. This can only be done in the preferences.

[SamSaffron]

I think we would need all 4 options, but I am very concerned about real estate, how can we fit this here? At most we have space for a glyph imo.

[Catrin]

ok good point. I have forgotten the edit-button. Then I'll add the fourth option and remove the text from the button and just leave the glyph. ok?

[Catrin]

now (after the travis hopefully did not find any bugs or failing tests ;) ) there are all 4 options and only the glyph left in the button.

[SamSaffron]

Can you update the screen shot? @coding-horror any thoughts about this?

[Catrin]

Good Morning :) here is the new screenshot.

[coding-horror]

I think it looks fantastic!

[SamSaffron]

One last thing here, we really need the glyphs next to the text in the drop down (like we have now in the standard dropdown for topic notification levels)

[Catrin]

ok, I'll add them.

[Catrin]

This is what it looks like after the latest commit:

[coding-horror]

looks good! Regular is simply text no glyph, though I agree if we are using a glyph at the top we have to choose something to put there.

[SamSaffron]

we are so close :) thanks heaps.

I meant consistency with

So you probably need to add a glyph over there for regular (I am fine with the open circle) and then use same glyphs in both spots .

[Catrin]

no problem. I change the glyphs.
Should I add the circle glyph to the list next to regular or just show it in the button?
Meanwhile I try to unterstand why the build does not pass :-/

[SamSaffron]

Lets try with the glyph omitted for now.

These build failures do not look like they are your fault.

Can you merge in latest, it should fix it.

[Catrin]

next try :)

[SamSaffron]

much better, but one super last thing which is also awesome practice for you :)

we essentially have 2 areas of code that are doing exactly the same thing

Discourse.CategoryNotificationsButton and Discourse.NotificationsButton

Instead we should centralize this and only use Discourse.NotificationsButton passing it in all the differences (which is only the i18n key)

That way we don't need to carry around dupe code.

Once you do that can you rebase ?

[Catrin]

ohhh, I was so glad that it "somehow" worked ;) Not that easy to get into discourse.
But yes, I also considered moving the dublicated code up. I'll digg into that tonight...

[Catrin]

On 07 May 2014, at 22:14, Dung Quang notifications@github.com wrote:

is this something related to tracked and watched categories in user preferences ?

Yes, it is.
What I am trying to implement is, that you can change the notification level directly on the category page in addition to the possibility in the user preferences.

[coding-horror]

This is really great. When can we merge this?

[riking]

@Catrin Ping! What's your status? This looks great.

[Catrin]

Working on it. I do not want to put everything into the Discourse.NotificationsButton. So my new plan is: Having Discourse.NotificationsButton as a super class and TopicsNotificationsButton and CategoryNotificationsButton below.

[coding-horror]

Looking forward to it 👀 let us know how we can help

[coding-horror]

Again, let us know how we can help! Do you think this can be done by the end of the week?

[Catrin]

I am so sorry. I could not finish it. Too busy working on a different project (and my kids...).

[coding-horror]

OK no problem thanks for letting us know! We'll pick it up from here, I'd really like to get this in.

[nlalonde]

I'll finish this.

[coding-horror]

Thanks @nlalonde looking forward to it. And thank you @Catrin for getting us so far on what I think is a GREAT addition to Discourse. 💝

[nlalonde]

I merged this manually and implemented your suggestion to "have Discourse.NotificationsButton as a super class and TopicsNotificationsButton and CategoryNotificationsButton below."

This feature is very handy!

[Catrin]

Hey Neil,

great and great code :) Thank so much you for taking over.
(Next time I’ll finish my stuff :))

On 30 May 2014, at 00:28, Neil Lalonde notifications@github.com wrote:

I merged this manually and implemented your suggestion to "have Discourse.NotificationsButton as a super class and TopicsNotificationsButton and CategoryNotificationsButton below."

This feature is very handy!

—
Reply to this email directly or view it on GitHub.

[coding-horror]

@Catrin actually @nlalonde said it was kind of a pain to refactor the code, so it ultimately was asking a lot. Thank you for getting it started and pushing it along so far. Don't hesitate to propose other features on meta.discourse, even if you don't have time to implement them..