Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add diagnostic plots for convergence #49

Closed
mtazzari opened this issue Feb 20, 2020 · 2 comments · Fixed by #55
Closed

Add diagnostic plots for convergence #49

mtazzari opened this issue Feb 20, 2020 · 2 comments · Fixed by #55
Milestone
Code freeze

Comments

@mtazzari
Copy link
Collaborator

Following discussion on Wed afternoon, add two diagnostic plots to the automatically generated figures.
Purpose of these figures is to inform the user on the convergence status of the fit.
@mtazzari mtazzari added this to the Code freeze milestone Feb 20, 2020
@mtazzari mtazzari mentioned this issue Feb 20, 2020
Closed
@jeffjennings
Copy link
Collaborator

Just finishing/testing this. Will submit PR today

@jeffjennings jeffjennings mentioned this issue Feb 20, 2020
Merged
@jeffjennings
Copy link
Collaborator

Closing just to clear now: PR #55 does this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Code freeze
Development

Successfully merging a pull request may close this issue.

Convergence diagnostics discsim/frank
2 participants
@mtazzari @jeffjennings