Skip to content
This repository has been archived by the owner on Mar 6, 2022. It is now read-only.

Add Member.timeout #43

Closed
wants to merge 1 commit into from
Closed

Add Member.timeout #43

wants to merge 1 commit into from

Conversation

MarzaElise
Copy link

Summary

Added Member.timeout for ease of use

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

Confirmations

  • I have checked the open PRs and no PR exists like this one.
  • My PR focuses on only one issue/change.

@MarzaElise
Copy link
Author

how tf do i request review- did github change UI?

Hype3808
Hype3808 approved these changes Jan 3, 2022
View reviewed changes
Copy link
Contributor

@Hype3808 Hype3808 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm needa wait for @nerdguyahmad 's opinion tho...

@Hype3808
Copy link
Contributor

Hype3808 commented Jan 3, 2022

needa wait for #33 to be merged

@izxxr
Copy link
Collaborator

izxxr commented Jan 4, 2022

I'm not fan of this, It has many inconsistencies.

@izxxr izxxr closed this Jan 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Hype3808 Hype3808 Hype3808 approved these changes

@VincentRPS VincentRPS VincentRPS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MarzaElise @Hype3808 @izxxr @VincentRPS