Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering: unsupported traits with sub-components targeting smithy.api#Unit #1297

Closed
kubukoz opened this issue Nov 15, 2023 · 1 comment · Fixed by #1325
Closed

Rendering: unsupported traits with sub-components targeting smithy.api#Unit #1297

kubukoz opened this issue Nov 15, 2023 · 1 comment · Fixed by #1325
Assignees
Labels
bug Something isn't working

Comments

@kubukoz
Copy link
Member

kubukoz commented Nov 15, 2023

Version: 0.18.3

$version: "2"

namespace input

@trait
union myTrait {
    u: Unit
}

@myTrait(u: {

})
string Example

This fails with:

Stack trace

scala.NotImplementedError: Unsupported case: (software.amazon.smithy.model.node.ObjectNode@d6514560,Unit)
	at smithy4s.codegen.internals.SmithyToIR.unfoldNodeAndTypeP(SmithyToIR.scala:1375)
	at smithy4s.codegen.internals.SmithyToIR.unfoldNodeAndType(SmithyToIR.scala:1286)
	at smithy4s.codegen.internals.SmithyToIR.$anonfun$unfoldTrait$1(SmithyToIR.scala:1177)
	at smithy4s.codegen.internals.recursion$.hylo(recursion.scala:41)
	at smithy4s.codegen.internals.recursion$.$anonfun$hylo$1(recursion.scala:41)
	at smithy4s.codegen.internals.TypedNode$AltValueTN$$anon$2.traverse(IR.scala:377)
	at smithy4s.codegen.internals.TypedNode$AltValueTN$$anon$2.traverse(IR.scala:371)
	at cats.Traverse$Ops.traverse(Traverse.scala:241)
	at cats.Traverse$Ops.traverse$(Traverse.scala:240)
	at cats.Traverse$ToTraverseOps$$anon$3.traverse(Traverse.scala:278)
	at smithy4s.codegen.internals.TypedNode$$anon$3.traverse(IR.scala:401)
	at smithy4s.codegen.internals.TypedNode$$anon$3.traverse(IR.scala:390)
	at cats.Traverse.map(Traverse.scala:134)
	at cats.Traverse.map$(Traverse.scala:133)
	at smithy4s.codegen.internals.TypedNode$$anon$3.map(IR.scala:390)
	at cats.Functor$Ops.map(Functor.scala:252)
	at cats.Functor$Ops.map$(Functor.scala:252)
	at cats.Functor$ToFunctorOps$$anon$5.map(Functor.scala:269)
	at smithy4s.codegen.internals.recursion$.hylo(recursion.scala:41)
	at smithy4s.codegen.internals.recursion$.ana(recursion.scala:63)
	at smithy4s.codegen.internals.SmithyToIR.smithy4s$codegen$internals$SmithyToIR$$unfoldTrait(SmithyToIR.scala:1177)
	at smithy4s.codegen.internals.SmithyToIR.$anonfun$hints$5(SmithyToIR.scala:968)
	at scala.collection.immutable.List.map(List.scala:246)
	at smithy4s.codegen.internals.SmithyToIR.smithy4s$codegen$internals$SmithyToIR$$hints(SmithyToIR.scala:968)
	at smithy4s.codegen.internals.SmithyToIR$ShapeExt.$anonfun$alts$1(SmithyToIR.scala:1041)
	at scala.collection.StrictOptimizedIterableOps.map(StrictOptimizedIterableOps.scala:100)
	at scala.collection.StrictOptimizedIterableOps.map$(StrictOptimizedIterableOps.scala:87)
	at scala.collection.convert.JavaCollectionWrappers$JCollectionWrapper.map(JavaCollectionWrappers.scala:98)
	at smithy4s.codegen.internals.SmithyToIR$ShapeExt.alts(SmithyToIR.scala:1032)
	at smithy4s.codegen.internals.SmithyToIR$$anon$1.unionShape(SmithyToIR.scala:269)
	at smithy4s.codegen.internals.SmithyToIR$$anon$1.unionShape(SmithyToIR.scala:111)
	at software.amazon.smithy.model.shapes.UnionShape.accept(UnionShape.java:47)
	at smithy4s.codegen.internals.SmithyToIR.$anonfun$allDecls$2(SmithyToIR.scala:105)
	at scala.collection.immutable.List.flatMap(List.scala:293)
	at smithy4s.codegen.internals.SmithyToIR.allDecls(SmithyToIR.scala:105)
	at smithy4s.codegen.internals.SmithyToIR$.apply(SmithyToIR.scala:52)
	at smithy4s.codegen.internals.CodegenImpl$.$anonfun$generate$14(CodegenImpl.scala:161)
	at scala.collection.immutable.List.map(List.scala:246)
	at smithy4s.codegen.internals.CodegenImpl$.generate(CodegenImpl.scala:161)
	at smithy4s.codegen.internals.CodegenImpl$.generate(CodegenImpl.scala:44)
	at smithy4s.codegen.Codegen$.generate(Codegen.scala:22)
	at smithy4s.codegen.Codegen$.generateToDisk(Codegen.scala:25)
	at smithy4s.codegen.cli.Main$.$anonfun$main$1(Main.scala:46)
	at smithy4s.codegen.cli.Main$.$anonfun$main$1$adapted(Main.scala:44)
	at scala.util.Either.map(Either.scala:382)
	at smithy4s.codegen.cli.Main$.main(Main.scala:44)
	at smithy4s.codegen.cli.Main.main(Main.scala)

So far I haven't found any other unsupported cases, it seems to be Unit in particular.

@kubukoz kubukoz added the bug Something isn't working label Nov 15, 2023
@denisrosca
Copy link
Contributor

I'm going to take a stab at this.

@Baccata Baccata changed the title Rendering: "scala.NotImplementedError: unsupported case" Rendering: unsupported traits with sub-components targeting smithy.api#Unit Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants