Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP codegen: should probably use sources instead of imports #1459

Closed
kubukoz opened this issue Mar 28, 2024 · 1 comment · Fixed by #1518
Closed

LSP codegen: should probably use sources instead of imports #1459

kubukoz opened this issue Mar 28, 2024 · 1 comment · Fixed by #1518

Comments

@kubukoz
Copy link
Member

kubukoz commented Mar 28, 2024

As per https://smithy.io/2.0/guides/smithy-build-json.html#using-smithy-build-json:

imports - Provides a list of model files and directories to load when validating and building the model. Imports are a local dependency: they are not considered part of model package being built, but are required to build the model package.

sources - Provides a list of relative files or directories that contain the models that are considered the source models of the build.

We currently generate imports.

@Baccata
Copy link
Contributor

Baccata commented Mar 29, 2024

well let's change it then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants