Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Static Singletons #1637

Closed
trisyoungs opened this issue Aug 16, 2023 · 0 comments · Fixed by #1766
Closed

Remove Static Singletons #1637

trisyoungs opened this issue Aug 16, 2023 · 0 comments · Fixed by #1766
Assignees
@rprospero
Labels
Scope: Design Related to fundamental code design, algorithm use etc. Type: Enhancement Enhancement for existing feature
Projects
Overview

Comments

@trisyoungs
Copy link
Member

Describe the feature / issue
There are currently two remaining static singletons in the code which we should endeavour to remove in the interests of data management and locality when multiple Dissolve objects are required.

The two singletons in question are:

  • std::vector<KeywordBase *> KeywordStore::allKeywords_ in src/keywords/store.cpp
  • std::vector<Module *> Module::instances_ in src/module/module.cpp
@trisyoungs trisyoungs added Type: Enhancement Enhancement for existing feature Scope: Design Related to fundamental code design, algorithm use etc. labels Aug 16, 2023
@github-actions github-actions bot added this to Design in Overview Aug 16, 2023
@rprospero rprospero self-assigned this Dec 6, 2023
@rprospero rprospero mentioned this issue Dec 12, 2023
Merged
@rprospero rprospero mentioned this issue Jan 17, 2024
Merged
Overview automation moved this from Design to Complete Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rprospero rprospero

Labels
Scope: Design Related to fundamental code design, algorithm use etc. Type: Enhancement Enhancement for existing feature
Projects
Overview
Complete
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1637 dynamic keywords disorderedmaterials/dissolve
2 participants
@rprospero @trisyoungs