Build for Apple Silicon #1743
Merged
Build for Apple Silicon #1743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Spitz <noella.spitz@ndw2544mac.isis.cclrc.ac.uk>
trisyoungs
reviewed
Jan 26, 2024
Comment on lines
114
to
125
| install_name_tool -change /usr/local/opt/ftgl/lib/libftgl.2.dylib @rpath/libftgl.2.dylib bin/dissolve-gui.app/Contents/MacOS/dissolve-gui | ||
|
|
||
| cd ../ | ||
|
|
||
| # Deploy Conan dependencies for ease | ||
| mkdir deploy && cd deploy | ||
| conan install .. -g deploy -s arch=armv8 | ||
|
|
||
| # Copy over ftgl so it can be shipped with the bundle | ||
| mkdir ftgl | ||
| cp $(brew --prefix ftgl)/lib/libftgl.2.dylib ftgl | ||
| cp $(brew --prefix ftgl)/lib/libftgl.2.1.3.dylib ftgl |
There was a problem hiding this comment.
Regarding the rename and copy, would it be slightly neater to make our ftgl dir (at the end of the stage), copy the libs, and then apply install_name_tool?
There was a problem hiding this comment.
I actually realised its best to remove the install_name_tool call as it will not work without notorisation!
Co-authored-by: Tristan Youngs <tristan.youngs@stfc.ac.uk>
trisyoungs
approved these changes
Jan 26, 2024
rprospero
added a commit
that referenced
this pull request
Mar 11, 2024
Co-authored-by: Spitz <noella.spitz@ndw2544mac.isis.cclrc.ac.uk> Co-authored-by: Adam Washington <adam.washington@stfc.ac.uk> Co-authored-by: Tristan Youngs <tristan.youngs@stfc.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a GitHub workflow for apple silicon. This specific workflow is to be used on intel GH runners, as it is configured to crossbuild. Currently there is no codesigning step, so in order to open the application, you will have to run these commands first:
You may have to right click + 'Open' the first time in order to bypass security.
Notes
brew install ftgl