New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Benchmarks 2024 #1764
Fix Benchmarks 2024 #1764
Conversation
d3804cd
to
b80310e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part is unneeded now
@trisyoungs I agree about desiring a single source of truth for the version numbers. Unfortunately, it's less clear on how to get there. Here's the options that I've looked at:
|
Comprehensive, and totally correct, assessment @rprospero. Think you've convinced me that 6) is the best option with the least hassle! |
Co-authored-by: Noella Spitz <101950441+rhinoella@users.noreply.github.com>
Co-authored-by: Noella Spitz <101950441+rhinoella@users.noreply.github.com>
Co-authored-by: Noella Spitz <101950441+rhinoella@users.noreply.github.com>
Co-authored-by: Noella Spitz <101950441+rhinoella@users.noreply.github.com>
This PR addresses a couple of issues with the
benchmarks.yml
workflow. The initial error was for a missing header (<oneapi/dpl/iterator>
) but this turned out to be a trivial fix - the "pure" Linux builds (of which the benchmarks workflow is one example) leverages conan, and ourCMakeLists.txt
wasn't explicitly passing on paths to theonedpl
package.I have also modified the workflow to always run, so we can benchmark PRs, but to only push benchmark results if on
develop
.One small thing for general comment - it would be nice to have a single source of truth for the versions of the various packages we use. Nix and conan are independent in that sense right now, so thoughts on harmonising this are welcome.