Analysis Refactoring - Part 2 #1795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trisyoungs
approved these changes
Mar 11, 2024
Comment on lines
+107
to
+110
| // Normalise by A site population | ||
| dAxisAngleNormaliser.normaliseDivide(double(a.sites().size())); | ||
| // Normalise by B site population density | ||
| dAxisAngleNormaliser.normaliseDivide(double(b.sites().size()) / targetConfiguration_->box()->volume()); |
There was a problem hiding this comment.
Looking at all these uses of the DataNormaliserND classes it feels more and more like we should rename them to reflect what they are actually doing, and that is (for the most part) just "operating" on data. Normalisation to a value or to spherical shell are specific examples of operations, but normaliseDivide is actually just divide in reality. As a follow-on issue I'd suggest we do a rename of the classes to DataOperatorND which can contain both the specific functions (e.g. normaliseTo and normaliseBySphericalShell) as well as generics like divide() and multiply().
Co-authored-by: Tristan Youngs <tristan.youngs@stfc.ac.uk>
rhinoella
pushed a commit
that referenced
this pull request
Apr 2, 2024
Co-authored-by: Tristan Youngs <tristan.youngs@stfc.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues work towards #1769, following on from #1789.
Addresses the following:
angleanglesystem testaxisAngleaxisAnglesystem testdAngle