Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed broken assertion #1838

Merged
merged 3 commits into from Apr 10, 2024
Merged

Conversation

RobBuchananCompPhys
Copy link
Contributor

@RobBuchananCompPhys RobBuchananCompPhys commented Apr 9, 2024

develop branch was failing due to an undeclared variable atomTypeI_ that had somehow got through unit tests

Copy link
Member

@trisyoungs trisyoungs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I caught this in my yet-to-be-reviewed-or-merged PR #1837, but yours can certainly go in ahead of mine. It shouldn't have broken the CI, however, since the assert only gets compiled in if we're in DEBUG mode.

@rprospero rprospero changed the title removed assertion fix: removed broken assertion Apr 10, 2024
@rprospero rprospero merged commit f19f972 into develop Apr 10, 2024
9 checks passed
@rprospero rprospero deleted the fix/remove_undeclared_atomType branch April 10, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants