Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove CMakeLists from packaged examples #1851

Merged
merged 2 commits into from Apr 12, 2024
Merged

Conversation

rhinoella
Copy link
Contributor

Remove unecessary CMake files from Dissolve example data.

Copy link
Member

@trisyoungs trisyoungs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately it's not that simple! The examples get registered as tests, hence the CMakeLists.txt. What you'll have to do instead is modify the examples/package-examples bash script to exclude the CMakeLists.txt from the generated zip...

@rhinoella rhinoella changed the title refactor: Remove CMakeLists from examples fix: Remove CMakeLists from packaged examples Apr 12, 2024
Copy link
Member

@trisyoungs trisyoungs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest that neater way would be to modify the find command:

FILES=( $(find ./ -mindepth 2 -type f -not -regex '.*/_.*' -not -name CMakeLists.txt) )

@rhinoella rhinoella merged commit 9bc2da2 into develop Apr 12, 2024
9 checks passed
@rhinoella rhinoella deleted the example-cmake-remove branch April 12, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants