Client configuration for streaming connections

[itaibenari]

Currently if you create a streaming connection it defaults to timeout after 60000 ms. In order to override it you must pass a client which is configured to not timeout:

object StreamClient {
  import com.ning.http.client.{AsyncHttpClient, AsyncHttpClientConfig}
  import com.ning.http.client.providers.netty.NettyAsyncHttpProviderConfig

  lazy val client = new AsyncHttpClient(config)
  lazy val config = new AsyncHttpClientConfig.Builder()
      .setRequestTimeoutInMs(-1)
      .setAsyncHttpClientProviderConfig(
        new NettyAsyncHttpProviderConfig().addProperty(
          NettyAsyncHttpProviderConfig.BOSS_EXECUTOR_SERVICE, bossExecutor
        )
      ).build()
  lazy val bossExecutor =
      java.util.concurrent.Executors.newCachedThreadPool(DaemonThreads.factory)
}

Http(client = StreamClient.client)

It would be nice to make this setting more streamlined in a similar way to how promise timeout is set.
Unless there is an easier way I am not aware of that is...

[softprops]

I feel like making the dispatch Defaults public would help a bit. Otherwise, those providing builders are going to have to resort to the same kind of copy and paste code

[itaibenari]

Since "reboot" has built in support for streams it makes sense to me that it should be easier for new users to make use of this feature without resorting to investigate the source code of dispatch and API of async-http-client. Changing Defaults is a step in the right direction though.

[n8han]

Geez guys, can't Dispatch keep anything private? :)

I didn't have time to come up with a great Defaults interface for 0.9.3 and needed some freedom to redo it in the future. There should really be a method on Http for building on the default configuration. I'll push some code here in a bit.

With 0.9.3 you'll have to live with some config boilerplate, but at least it's forwards-compatible config boilerplate!

[n8han]

Also now that I'm aware of this issue I'm inclined to default to not having a request timeout. Any thoughts on the downsides of that?

[itaibenari]

None in my eyes.