Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new domains #95

Closed
wants to merge 1 commit into from
Closed

Add new domains #95

wants to merge 1 commit into from

Conversation

@apollonin
Copy link

apollonin commented Nov 8, 2017

@martenson , hi! are you going to accept this PR?
@egorsmkv , looks like here is potential conflict in your PR

@martenson
Copy link
Member

martenson commented Nov 8, 2017

@apollonin It has conflicts and it does not adhere to the standard of having no 3rd-and-below level domains.

@egorsmkv I am sorry for not responding earlier. Are you planning to modify this PR according to what I stated above?

@egorsmkv
Copy link
Author

egorsmkv commented Nov 8, 2017

@apollonin I recommend you fork this project and add yourself new disposable domains. Perhaps, the author doesn't accept my pull request (see the PR's date).

@apollonin
Copy link

@egorsmkv author is here =) Please, improve your PR and it should be accepted.

@egorsmkv
Copy link
Author

egorsmkv commented Nov 8, 2017

Okay, @martenson

I close this PR and create new.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants