Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregate multiple batteries into one state #4

Open
tv42 opened this issue May 21, 2016 · 2 comments
Open

Aggregate multiple batteries into one state #4

tv42 opened this issue May 21, 2016 · 2 comments

Comments

@tv42
Copy link

tv42 commented May 21, 2016

I feel like many apps will only want to display a single battery indicator -- it's unlikely the user cares whether their laptop hardware has a single battery controller, or multiple. To avoid lots of (bad) copies of this logic, or probably more likely apps reporting just the first battery, perhaps provide a func Summarize() (*Battery, error)?

@tv42 tv42 changed the title Aggregate multiple batteries into one State Aggregate multiple batteries into one state May 21, 2016
@dmitshur
Copy link
Contributor

To avoid lots of (bad) copies of this logic, or probably more likely apps reporting just the first battery

That's a good argument.

@KenjiTakahashi
Copy link
Member

Sounds reasonable, yes. PRs welcome :-). Otherwise, I'll try to get to this, as time/will permits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants